Skip to content

Generation config boolean defaults #43000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zucchini-nlp merged 13 commits into from
Jan 8, 2026
Merged

Generation config boolean defaults #43000

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bda4a76
push
zucchini-nlp Dec 22, 2025
d2da9b0
fix a few tests
zucchini-nlp Dec 22, 2025
e59b321
why no tests are failing, suspicious
zucchini-nlp Dec 22, 2025
ca46e33
one tiny fix
zucchini-nlp Dec 22, 2025
70fdb01
maybe?
zucchini-nlp Dec 23, 2025
a635307
typo
zucchini-nlp Dec 23, 2025
91ae7d8
clvp has incorrect config types
zucchini-nlp Dec 23, 2025
b40d249
nit
zucchini-nlp Dec 23, 2025
3f07426
Merge remote-tracking branch 'upstream/main' into gen-config-defaults
zucchini-nlp Jan 5, 2026
1aeb0ea
docstring and revert unrelated trainer
zucchini-nlp Jan 8, 2026
a6e71a8
forgot to revert this one
zucchini-nlp Jan 8, 2026
1608238
Update src/transformers/generation/configuration_utils.py
zucchini-nlp Jan 8, 2026
6f68cc0
delete the prev fix and add small comment
zucchini-nlp Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
why no tests are failing, suspicious
  • Loading branch information
@zucchini-nlp
zucchini-nlp committed Dec 22, 2025
commit e59b321d1c936a428d58148354864d4b4add4cba
2 changes: 1 addition & 1 deletion tests/generation/test_configuration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_kwarg_init(self):
"""Tests that we can overwrite attributes at `from_pretrained` time."""
default_config = GenerationConfig()
self.assertEqual(default_config.temperature, None)
self.assertEqual(default_config.do_sample, False)
self.assertEqual(default_config.do_sample, None)
self.assertEqual(default_config.num_beams, None)

config = GenerationConfig(
Expand Down