Repository navigation
Conversation
| "rollup": "^2.9.1", | ||
| "rollup-plugin-peer-deps-external": "^2.2.0" | ||
| "rollup-plugin-peer-deps-external": "^2.2.0", | ||
| "@wojtekmaj/enzyme-adapter-react-17": "^0.6.6" |
There was a problem hiding this comment.
this looks like a private fork and package, isn't the official package ready yet? If not, I wouldn't rush with the upgrade
There was a problem hiding this comment.
this looks like a private fork and package, isn't the official package ready yet? If not, I wouldn't rush with the upgrade
I did a bit of research, an at first glace it looks like they just gave up. The issue for supporting React 17 enzymejs/enzyme#2429 is stuck since almost 2 years now, while the fork we chose here looks seriously maintained and widely adopted (550k weekly downloads, the activity on the repo looks legitimate: https://github.com/wojtekmaj/enzyme-adapter-react-17). At this point the choice is either trust this fork or give up on having enzyme.
There was a problem hiding this comment.
Yes I agree, enzyme feels kind of dead, so unless you want to move to something else altogether for testing I think using the fork is the way to go. We use the same fork in Indico BTW.
There was a problem hiding this comment.
Since the fork is now also officially long dead: https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl, migration to RTL seems to me like a most viable path to move forward (supports React 16-19): https://testing-library.com/docs/react-testing-library/migrate-from-enzyme/
|
What's the reason for removing package-lock.json altogether? |
My bad, I pushed an updated version of it |
* Adds critical blocker documentation for react-overridable v1.2.0 which only supports up to React 17 * Adds ecosystem blocker analysis table showing react-overridable, react-searchkit, and react-invenio-forms dependencies * Updates migration phase structure: Phase 0 (react-overridable) must be done first before react-searchkit and react-invenio-forms * Updates target state table to include ecosystem packages with blocker status * Updates scope to include ecosystem packages as required migration targets * Updates STOP PROCEED CONDITION to explicitly list all three ecosystem blocks * Adds react-overridable migration details section with repository, branch, tasks, and verification steps * Updates execution plan to prioritize ecosystem packages (0-2) before application packages (3+) * Updates timeline to include Phase -1: Ecosystem Packages Migration (8-11 days) * Reference PR: indico/react-overridable#14 Co-Authored-by: Claude Opus 4.6 <noreply@anthropic.com>
See #13
Also replaces https://www.npmjs.com/package/enzyme-adapter-react-16 with https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17