Skip to content

fix(lab): remove css that places the statusbar above the header - #3766

Merged
imhoffd merged 2 commits into
developfrom
fix-lab-statusbar
Nov 30, 2018
Merged

imhoffd merged 2 commits into
developfrom
fix-lab-statusbar

Conversation

@brandyscarney

Copy link
Copy Markdown
Member

fixes android and windows statusbar so it is on top of the header in lab

references #3069

before:
localhost_8200_

aftah:
localhost_8200_ 1

fixes android and windows statusbar so it is on top of the header in lab

references #3069
this fixes android heading in v3
@brandyscarney

brandyscarney commented Nov 28, 2018 •

Copy link
Copy Markdown
Member Author

Note that this technically will break Android on Chrome in v3, but it's already broken on iOS in Chrome since before this PR, and the fix will need to be in v3. I don't think this PR breaks it so much as it exposes that forced statusbar padding is now broken in latest Chrome.

@imhoffd
imhoffd merged commit b37fa03 into develop Nov 30, 2018
@imhoffd
imhoffd deleted the fix-lab-statusbar branch November 30, 2018 21:44
imhoffd added a commit that referenced this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants