Skip to content

[@ionic-cli/v1-toolkit] Upgrade depedency to gulp 4 - fix issue #4114 - #4509

Merged
imhoffd merged 13 commits into
ionic-team:developfrom
duniter-cesium:develop
Aug 12, 2020
Merged

imhoffd merged 13 commits into
ionic-team:developfrom
duniter-cesium:develop

Conversation

@blavenie

Copy link
Copy Markdown
Contributor

Upgrade gulp@4.0.2, to fix build error, on Node 12+
See #4114 (comment)

@blavenie

Copy link
Copy Markdown
Contributor Author

Now it seems to work fine.

This patch allow:

  • to use Gulp 4 syntax in <IONIC_PROJECT>/gulpfile.js
  • Failed if gulp V3 still use, but display an explicit error (with a link to the gulp v4 migration guide);
  • Wait end of tasks (e.g. ionic serve will wait end of ionic:serve:before - fix an existing issue);

@imhoffd imhoffd linked an issue Aug 11, 2020 that may be closed by this pull request
@imhoffd

imhoffd commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

@blavenie You can run npm run lint:fix to fix all the lint issues reported in CI.

@imhoffd
imhoffd merged commit b2d1a66 into ionic-team:develop Aug 12, 2020
@imhoffd

imhoffd commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Thanks @blavenie! This will be released shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@ionic/v1-toolkit] Issue with outdated gulp dependency

2 participants