Add a global variable 'ignored_message'#56
Closed
JustCodingYe wants to merge 1 commit intojaraco:mainfrom
Closed
Conversation
…ignored message when a CSSStyleDeclaration: Unexpected token error occurs, allowing the user to retrieve that message.
Owner
|
Thanks for the proposal. Unfortunately, I don't think this approach is sound. In general, global variables are dangerous. As a signal used as a public interface, they're even more dangerous. What I recommend instead: file an issue describing your use-case and why it would be useful to know this value of logic. From there, we can assess the problem and explore different options for achieving your objective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a global variable 'ignored_message', which is used to expose the ignored message when a
CSSStyleDeclaration: Unexpected tokenerror occurs, allowing the user to retrieve that message for further processing, such as continuing to parse the ignored content.