move java rule impls to impl and add wrappers#1
Open
priceofcode wants to merge 1 commit intobase-migrate-java-rules-to-impl-r-11722390from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core Bazel Java rule wiring and relocates large portions of implementation code, which can affect rule loading/visibility and build behavior despite being largely a refactor.
Overview
Refactors the Java Starlark rules to separate public rule definitions from their implementations: core logic for
java_binary,java_library,java_import, and related helpers is moved into newjava/common/rules/impl/*.bzlmodules, while new Bazel-facing wrappers are added underjava/bazel/rulesto proxy into these impls.bazel_java_binary.bzlis slimmed down and now exports shared pieces (bazel_base_binary_impl,make_binary_rule,BASE_BINARY_ATTRS) whilejava_testis moved into a dedicatedbazel_java_test.bzl;bazel_java_binary_wrapper.bzlvisibility is widened to//java. Build packaging is updated via newfilegroupwiring (java/common/rules/BUILD,java/common/rules/impl/BUILD, andjava/common/BUILD), the placeholderempty.bzlis removed, and Android lint option tokenization is switched to usesemantics.tokenize_javacoptsdirectly.Written by Cursor Bugbot for commit bbe42c1. This will update automatically on new commits. Configure here.