Skip to content

move java rule impls to impl and add wrappers#1

Open
priceofcode wants to merge 1 commit intobase-migrate-java-rules-to-impl-r-11722390from
priceofcode/migrate-java-rules-to-impl-r-11722390
Open

move java rule impls to impl and add wrappers#1
priceofcode wants to merge 1 commit intobase-migrate-java-rules-to-impl-r-11722390from
priceofcode/migrate-java-rules-to-impl-r-11722390

Conversation

@priceofcode
Copy link

@priceofcode priceofcode commented Feb 14, 2026

Note

Medium Risk
Touches core Bazel Java rule wiring and relocates large portions of implementation code, which can affect rule loading/visibility and build behavior despite being largely a refactor.

Overview
Refactors the Java Starlark rules to separate public rule definitions from their implementations: core logic for java_binary, java_library, java_import, and related helpers is moved into new java/common/rules/impl/*.bzl modules, while new Bazel-facing wrappers are added under java/bazel/rules to proxy into these impls.

bazel_java_binary.bzl is slimmed down and now exports shared pieces (bazel_base_binary_impl, make_binary_rule, BASE_BINARY_ATTRS) while java_test is moved into a dedicated bazel_java_test.bzl; bazel_java_binary_wrapper.bzl visibility is widened to //java. Build packaging is updated via new filegroup wiring (java/common/rules/BUILD, java/common/rules/impl/BUILD, and java/common/BUILD), the placeholder empty.bzl is removed, and Android lint option tokenization is switched to use semantics.tokenize_javacopts directly.

Written by Cursor Bugbot for commit bbe42c1. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant