switch to generated remote jdk configs and bump versions#2
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "@platforms//cpu:aarch64", | ||
| ], | ||
| sha256 = "314b04568ec0ae9b36ba03c9cbd42adc9e1265f74678923b19297d66eb84dcca", | ||
| strip_prefix = "zulu17.44.53-ca-jdk17.0.8.1-macosx_aarch64", |
There was a problem hiding this comment.
Dict iteration missing .items() and nested loop
High Severity
REMOTE_JDK_CONFIGS is a dict (from _make_version_to_remote_jdks() which returns {}), but for __, item in REMOTE_JDK_CONFIGS: iterates over the dict's keys (strings "8", "11", etc.) and tries to unpack each into two variables. This will crash on the first key "8" since a single-character string can't be unpacked into two variables. Even for two-character keys like "11", item would be the character "1", not a config struct. The iteration needs .items() and a nested loop over the list values to access individual config structs.


Note
Medium Risk
Changes the source and registration of toolchain JDK repositories and updates all pinned JDK binaries; mistakes could break toolchain resolution or CI due to bad URLs/hashes/strip prefixes.
Overview
Updates remote JDK provisioning to be generated from a single source of truth: adds
java/bazel/repositories_util.bzl(release matrix + URL/strip_prefix generation) and ajava/bazel:dump_remote_jdk_configsgenrule, then replaces the hand-writtenremote_jdk*_reposdefinitions injava/repositories.bzlwith a generated_REMOTE_JDK_CONFIGS_LISTand shared registration logic.Bumps the pinned remote JDK versions (notably Zulu JDK 8/11/17/21) and refreshes URLs/sha256/strip_prefix values, and adds a new
test/check_remote_jdk_configs_test(wired into CI on Ubuntu) that downloads each configured archive to validate hashes andstrip_prefix.Written by Cursor Bugbot for commit 18e0c3a. This will update automatically on new commits. Configure here.