Skip to content

Caffe2 API is undergoing changes #83

Open

Description

@jerryzh168

Caffe2 C++ API is undergoing changes since we are currently working on merging the caffe2 and pytorch backend. There might be breaking changes, but most of them should be easy to fix. For most updated version of caffe2::Tensor, please refer to: https://github.com/pytorch/pytorch/blob/master/caffe2/core/tensor.h

And we'll merge with pytorch Tensor: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/core/Tensor.h at some point. Please keep an eye on https://github.com/pytorch/pytorch and https://pytorch.org/ for announcements.

Activity

  1. changed the title [-]Caffe2 API is ongoing changes[/-] [+]Caffe2 API is undergoing changes[/+] on Nov 3, 2018
  2. rilesdg3 commented on Nov 8, 2018

    @rilesdg3

    I forked this project and updated parts of it to reflect the Caffe2 API changes as of 10 22 2018. I was able to get the rnn tutorial to run.

    All the necessary files to run only the rnn example can be found here

  3. beniz commented on Nov 8, 2018

    @beniz

    For full C++ Caffe2 code working with pytorch/caffe2 1.0 release and the non templated tensors, see https://github.com/jolibrain/deepdetect/tree/master/src/backends/caffe2 and jolibrain/deepdetect#510

    Note that this includes pure C++ Detectron inference and included new C++ operators we had to write. We'll PR back to pytorch whenever time allows and if there's interest.

  4. jerryzh168 commented on Nov 8, 2018

    @jerryzh168
    Author

    @rilesdg3 that's great! probably talk to author to merge?

  5. jerryzh168 commented on Nov 8, 2018

    @jerryzh168
    Author

    we have more API changes coming(e.g. method renaming), not just the template..

  6. beniz commented on Nov 9, 2018

    @beniz

    Is there a public list of forthcoming changes ?

  7. jerryzh168 commented on Nov 9, 2018

    @jerryzh168
    Author

    @beniz I think there will be announcement when the two Tensors are merged.

  8. rilesdg3 commented on Nov 12, 2018

    @rilesdg3

    @jerryzh168 will do, I will keep an eye open for the changes

  9. BIGBALLON commented on Dec 21, 2018

    @BIGBALLON

    Hi, @jerryzh168 .
    Is there any new process about the merge of two tensors?

  10. jerryzh168 commented on Dec 21, 2018

    @jerryzh168
    Author

    We're still removing tech debts in our codebase.

  11. alexge233 commented on Mar 22, 2019

    @alexge233

    @jerryzh168 I know it is a bit irrelevant, just asking for some info and an opinion:

    • Is caffe2 going to be deprecated in favour of ATen, Autograd?
    • For us who often have to use C++ should we keep working on caffe2 or switch to the above?
    • Is pytorch using Aten and Autograd in the background? I assume so, and I've familiarised my self with pytorch, so I'd prefer to have a similar approach when using C++
      Many thanks and much appreciate any advice/opinion :-)
  12. jerryzh168 commented on Oct 9, 2019

    @jerryzh168
    Author

    @alexge233 sorry for the late reply, we have merged TensorImpl in caffe2 and pytorch, right now caffe2::Tensor and aten::Tensor are thin wrappers around TensorImpl. To answer your question

    1. There won't be distinction of caffe2/pytorch any more, they are the same thing, you can use existing caffe2 abstractions to write operators or use ATen abstractions, but they are being merged, for new operators probably better to follow ATen I think
    2. It's the same thing, old caffe2 stuff should still be working, but if you want to write new operators, maybe better to put them in ATen folder
    3. Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions