Repository navigation
Add Rust based vss-service. - #34
Merged
Merged
Conversation
Contributor
Author
|
Rebased on top of main. |
jkczyz
reviewed
Nov 8, 2024
jkczyz
left a comment
Contributor
There was a problem hiding this comment.
Concept ACK. Need to read through the tests still.
jkczyz
reviewed
Nov 18, 2024
jkczyz
left a comment
Contributor
There was a problem hiding this comment.
Mostly nits on the tests. Verified that they match the Java integration tests. https://github.com/lightningdevkit/vss-server/blob/main/java/app/src/test/java/org/vss/AbstractKVStoreIntegrationTest.java
Contributor
Author
|
Addressed all current comments, lmk if it is good to squash or needs another round of review. |
jkczyz
approved these changes
Nov 21, 2024
jkczyz
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's squash and merge.
Contributor
Author
|
Will fix and squash ! |
Contributor
Author
|
Squashed with minor fixups, diff here: https://github.com/lightningdevkit/vss-server/compare/13496520de8a5ba61943c1bacf6c280be2c37ebb..2fc3fd3fb451e4f430e82efd98b5c84fa7dfb29e |
jkczyz
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Rust based vss-service.