[28.5] Preserve legacy PEPPOL export events - #11053
[28.5] Preserve legacy PEPPOL export events#11053Milica Đukić (djukicmilica) wants to merge 1 commit into
Conversation
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
Good Sense Reviewer - Round 1Recommendation: Accept with SuggestionsProblem-solution fit: Strong What this PR doesThis PR routes E-Document PEPPOL invoice and credit memo export back through the legacy PEPPOL BIS 3.0 XMLports. That restores the existing XMLport event surface for customizations while keeping the exported invoice and credit memo flow in the same code path. The logic change is small and targeted. I did not find a correctness issue in the code change itself. SuggestionsS1 (🟠 Moderate): Add a regression test for the legacy PEPPOL events Add a test that exports an invoice and a credit memo through this E-Document path with a subscriber to one legacy PEPPOL XMLport event. That proves future changes keep the customization contract this fix restores. Risk assessment and necessityRisk: Moderate. The PR deliberately restores an extensibility contract in document export. The remaining risk is that a future refactor can bypass the legacy XMLports again without a test catching it. Necessity: The change is needed to keep existing customizations working on the PEPPOL invoice and credit memo export path.
|
Summary
Restore the legacy PEPPOL BIS 3.0 invoice and credit memo XMLports in the E-Document PEPPOL export path.
The standalone
Sales Invoice - PEPPOL30andSales Cr.Memo - PEPPOL30XMLports bypass codeunit 1605PEPPOL Managementand the legacy XMLport events. Existing extensions subscribed to those events therefore no longer run during E-Document export.This change routes invoice and credit memo generation through the legacy XMLports again, preserving the existing customization contract while producing the built-in PEPPOL 3.0 Sales format used by this release.
Validation
git diff --check: passedEDoc PEPPOL BIS 3.0