Skip to content

[28.5] Preserve legacy PEPPOL export events - #11053

Open
Milica Đukić (djukicmilica) wants to merge 1 commit into
releases/28.5from
fix/peppol-legacy-events-28.5
Open

[28.5] Preserve legacy PEPPOL export events#11053
Milica Đukić (djukicmilica) wants to merge 1 commit into
releases/28.5from
fix/peppol-legacy-events-28.5

Conversation

@djukicmilica

@djukicmilica Milica Đukić (djukicmilica) commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Restore the legacy PEPPOL BIS 3.0 invoice and credit memo XMLports in the E-Document PEPPOL export path.

The standalone Sales Invoice - PEPPOL30 and Sales Cr.Memo - PEPPOL30 XMLports bypass codeunit 1605 PEPPOL Management and the legacy XMLport events. Existing extensions subscribed to those events therefore no longer run during E-Document export.

This change routes invoice and credit memo generation through the legacy XMLports again, preserving the existing customization contract while producing the built-in PEPPOL 3.0 Sales format used by this release.

Validation

  • AL editor diagnostics: no errors
  • git diff --check: passed
  • Verified invoice and credit memo legacy export paths
  • Diff is limited to codeunit 6165 EDoc PEPPOL BIS 3.0

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

@github-actions github-actions Bot added the Team: Integrations GitHub request for Integrations area label Sep 4, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

Problem-solution fit: Strong

What this PR does

This PR routes E-Document PEPPOL invoice and credit memo export back through the legacy PEPPOL BIS 3.0 XMLports. That restores the existing XMLport event surface for customizations while keeping the exported invoice and credit memo flow in the same code path.

The logic change is small and targeted. I did not find a correctness issue in the code change itself.

Suggestions

S1 (🟠 Moderate): Add a regression test for the legacy PEPPOL events

Add a test that exports an invoice and a credit memo through this E-Document path with a subscriber to one legacy PEPPOL XMLport event. That proves future changes keep the customization contract this fix restores.

Risk assessment and necessity

Risk: Moderate. The PR deliberately restores an extensibility contract in document export. The remaining risk is that a future refactor can bypass the legacy XMLports again without a test catching it.

Necessity: The change is needed to keep existing customizations working on the PEPPOL invoice and credit memo export path.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11053 round=1 by=alexei-dobriansky at=2026-09-04T22:15:18Z lastSha=0da0435a3df9e2a36beebebb40354ed120f5af7f reviewKey=36ada986b14e4573f926c09a1b86a384683547741f9d23f8fdbc887eefb34036 suggestions=S1@0283b90b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants