Skip to content

[29.0] SOA: Clear previous search filter - #11071

Open
VolodySyn wants to merge 1 commit into
releases/29.0from
bugs/649166
Open

[29.0] SOA: Clear previous search filter#11071
VolodySyn wants to merge 1 commit into
releases/29.0from
bugs/649166

Conversation

@VolodySyn

@VolodySyn VolodySyn commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#649166

Summary
Clears the stale SystemId filter before processing a new item search. This prevents previous search results from restricting subsequent searches and ensures empty searches correctly reset the search state.

@VolodySyn
VolodySyn requested a review from a team September 4, 2026 15:05
@VolodySyn
VolodySyn requested a review from a team as a code owner September 4, 2026 15:05
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: SCM GitHub request for SCM area labels Sep 4, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Sep 4, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change clears the SystemId filter on the Item record before a new Sales Order Agent item search is processed. That removes stale record narrowing from the previous search while keeping the existing early exit for repeated filters and empty searches. The code then rebuilds the item candidate filter from the current search text, so the new search is not limited by the prior selected item.

Problem-solution fit

Fit: Strong

The reported problem is that a successful item search can leave a SystemId filter behind and affect the next search. The one-line change targets that leftover filter before the new item filter is built, which matches the described failure mode.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: The regression surface is the Sales Order Agent item lookup and multi-item availability search. The change only removes a stale SystemId filter after the search text has changed, so it should not affect normal item filtering, availability filtering, or variant resolution.

Necessity: The change is needed because a stale record filter can make later searches look empty or too narrow even when matching items exist. The scope is small and limited to clearing that stale search state.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11071 round=1 by=alexei-dobriansky at=2026-09-04T18:15:13.4649390Z lastSha=77636f550e9d8201f251cafdcfabab4bcb20d01f reviewKey=c6a8969cd887cdd1b078d6633e4243196fa175e8b3ae510bdf0ee855806cc50c suggestions=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants