Repository navigation
OpenAPI.NET 1.2.0 is not backwards compatible with 1.1.x #487
Description
Activity
This just bit me
System.MissingMethodException: Method not found: 'Void Microsoft.OpenApi.Any.OpenApiString..ctor(System.String)'.Added a PR: #489
Would be nice to merge it, bump your version and unlist 1.2.0
Darrel (@darrelmiller) any chance for your input on this one please?
Ugh. Apparently optional parameters have source backward compatibility but not binary backward compatibility.
Ugh. Apparently optional parameters have source backward compatibility but not binary backward compatibility.
Yep :) Compiler magic...
- added a commit that references this issue
on Jun 24, 2020 With 1.2.1, the previous
OpenApiStringerror just got transformed intoMethod not found: 'Void Microsoft.OpenApi.Writers.OpenApiJsonWriter..ctor(System.IO.TextWriter)'.
🤔Hasan (@hasancemcerit) PR ongoing to fix it: #492
Reacted by HasanIt's fixed. 1.2.2 has no breaking changes, and the others got delisted.
Darrel (@darrelmiller) This can probably be closed now :)
Reacted by Hasan and Fabian Niederer- added a commit that references this issue
on Jun 25, 2020 David Cumps (@CumpsD) Thank you for your help with this.
Version 1.2.0 is not backwards compatible with 1.1.x. For example, the constructor of OpenApiString has changed from:
to
If another project references the old version, it cannot find the constructor since its signature has changed. It would have been better to add a new constructor or increase the major version number of the package (if you adhere to semantic versioning). At the very least, breaking api changes should be documented in the release notes.