Skip to content

🐛 Add missing link references for "God Objects" and Ternary enum definition #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabritto merged 3 commits into from
Apr 3, 2023
Merged

🐛 Add missing link references for "God Objects" and Ternary enum definition #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7ac24b
🐛 Fix missing link reference to "God Objects"
babakks Aug 7, 2022
652ca94
🐛 Add missing link references for `Ternary` enum definition
babakks Aug 7, 2022
846cbae
Update codebase/src/compiler/checker.md
babakks Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions codebase/src/compiler/checker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Switching to different files means probably making [god objects][god], and the c
We want to avoid additional calls for ambient context. There are architectural patterns for this, but it's better
to assume good faith that they've been explored already (8 years down the line now.)

[god]: https://en.wikipedia.org/wiki/God_object

Anyway, better to get started somewhere. I [asked online](https://twitter.com/orta/status/1148335807780007939)
about how people would try to study a file like this and I think one of the best paths is by following a
particular story as a file gets checked.
Expand Down Expand Up @@ -225,4 +227,6 @@ TODO: what are substituted types?
[22]: <src/compiler/checker.ts - function eachTypeRelatedToSomeType>
[23]: https://github.com/microsoft/TypeScript/blob/db9e0079/src/compiler/checker.ts#L18872
[23]: <src/compiler/checker.ts - function structuredTypeRelatedTo>
[24]: https://github.com/microsoft/TypeScript/blob/eb430f27/src/compiler/types.ts#L6097
[24]: <src/compiler/types.ts - export const enum Ternary>
<!-- prettier-ignore-end -->