tsc complains require() file path outside of rootDir only when await import() is used

TypeScript Version: 4.0.0-dev.20200516

Search Terms: commonjs, esmodule, rootDir

Code
Consider this file:

onst {version: VERSION} = require('../package.json');
console.log(VERSION);

async function foo() {
    let obj = {};
    console.log(obj);
}

export async function bar() {
    console.log('foo');
    await foo();
}

And this file:

const {version: VERSION} = require('../package.json');
console.log(VERSION);

async function foo() {
    let obj = await import('./anotherFile');
    console.log(obj);
}

export async function bar() {
    console.log('foo');
    await foo();
}

Expected behavior:
Running tsc to compile them, they should both succeed or both fail?
Actual behavior:
The first file can be compiled smoothly, while the second was complained about error TS6059 and error TS6307.
Playground Link: https://glitch.com/~aromatic-bittersweet-biplane

Related Issues:

I am seeing this bug triggered by a slightly different reason: adding an import() type annotation.

I have created a minimal reproduction here: https://github.com/TypeStrong/ts-node-repros/tree/ts-38611
It executed here: https://github.com/TypeStrong/ts-node-repros/runs/682702614

declare const require: any;

// Bug occurs when an import() is in the file
const a: typeof import('./other') = null as any

function foo() {
    const a = require('../outside-of-rootdir/foo'); // Semantic error: File ... is not under 'rootDir' ...
    const {other}: {other: string} = require('./other'); // No error here, even though is semantically invalid, because `other` is of type `number`.
    
    // It appears as though the resolver is trying to locate the targets of require() calls, but the typechecker does not care.
}

ychi

ychi your repro link seems to be not working, Can you please share the repro again. Thanks

Andrew Bradley (@cspotcode)

Actually Andrew Bradley (@cspotcode) repro seems to be working.. Thanks.

Do not resolve require calls in typescript files even if it contains …

Navigation Menu

Repository navigation

`tsc` complains `require()` file path outside of rootDir only when `await import()` is used #38611

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

tsc complains require() file path outside of rootDir only when await import() is used #38611

Description

Activity

cspotcode commented on May 17, 2020

sheetalkamat commented on Jul 15, 2020

sheetalkamat commented on Jul 15, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`tsc` complains `require()` file path outside of rootDir only when `await import()` is used #38611