Repository navigation
Apply more TSLint rules #3994
Description
Including
- One variable declaration per variable statement (see Rule to limit variable statements to a single declaration palantir/tslint#525)
- Spaces, not tabs
- No space preceding colons
- Double quotes for strings (though, depending on TSLint's behavior on this, we can be flexible.
- No explicit types for inferrable entities
- use
namespaceinstead ofmodule(see Add no-internal-module rule palantir/tslint#517) -
else/catch/etc. on a different line (see Complement to [one-line]? palantir/tslint#88) - Space before
{in interfaces, classes, enums, any sort of attached statement body, or type annotation. - No trailing whitespace
- Forbid boolean/
undefinedparameters who aren't named. - Forbid
null
Any other suggestions?
Activity
weswigham commentedon Jul 23, 2015
We also need a rule to capture having
elseandcatchstatements on the line after the closing curly of the previous statement. Open issue on tslint requesting a rule for it.RyanCavanaugh commentedon Jul 23, 2015
Do we have one for spaces between
ifand(?weswigham commentedon Jul 23, 2015
We also need one for the space after a method declaration but before the method body, ie disallowing:
and
weswigham commentedon Jul 23, 2015
Also a rule for enforcing inferred typing on primitive literal declarations, ie
should be
weswigham commentedon Jul 23, 2015
The rule added that will be added from this PR should also be enabled to disallow the
modulekeyword for internal modules.weswigham commentedon Jul 23, 2015
Ryan Cavanaugh (@RyanCavanaugh)
"whitespace": [true, "check-branch"]should be covering that.weswigham commentedon Aug 24, 2015
From this PR:
A rule to forbid boolean parameters who aren't named.
weswigham commentedon Aug 25, 2015
...also a no trailing whitespace rule.
danquirk commentedon Aug 25, 2015
I tried to apply the no trailing whitespace rule locally but too many people are using editors where newline causes a smart indent that inserts whitespace. So then tslint flags tons of seemingly blank newlines as having trailing whitespace (because they're not simply a \n or \r\n). Would be nice to have on though.
Add tslint rules for microsoft#3994
Merge pull request #4458 from weswigham/tslint-rules