Skip to content

ci: switches to dedicated identity for promotion PRs - #8043

Merged
Vincent Biret (baywet) merged 4 commits into
mainfrom
ci/use-identity-for-promote
Sep 4, 2026
Merged

ci: switches to dedicated identity for promotion PRs#8043
Vincent Biret (baywet) merged 4 commits into
mainfrom
ci/use-identity-for-promote

Conversation

@baywet

Copy link
Copy Markdown
Member

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow retains unnecessary GITHUB_TOKEN write access and does not explicitly restrict the App token’s permissions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Switches shipped-API promotion automation from GITHUB_TOKEN to a dedicated GitHub App identity.

Changes:

  • Generates an App token for checkout and pull request operations.
  • Updates Git and GitHub CLI authentication.
  • Persists the App token for automated Git operations.
File summaries
File Description
.github/workflows/promote-shipped-apis.yml Uses the dedicated identity throughout the promotion workflow; App token permissions must be narrowed, and redundant write permissions for GITHUB_TOKEN removed.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/promote-shipped-apis.yml
Comment thread .github/workflows/promote-shipped-apis.yml

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): 9868e189ca60
Model: gpt-5.6-sol-fast

Overview

This change replaces the workflow's default GITHUB_TOKEN with a SHA-pinned GitHub App token and consistently passes it to checkout and GitHub CLI operations, while preserving the existing change detection, concurrency, and force-with-lease guards. The workflow is limited to pushes on main and manual dispatches, and the checked-out repository already retains the same token for later Git operations. The remaining concerns are credential-hygiene improvements or depend on unverified external configuration, so none establishes a publishable Critical, High, or Medium defect.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Promotion commit attribution should use the dedicated App slug and bot user ID.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

.github/workflows/promote-shipped-apis.yml:43

  • actions/checkout already persists the supplied App token for subsequent fetch/push operations. Writing it into a global insteadOf URL unnecessarily leaves the secret readable in the runner's global Git configuration (and the URL places the token in the username position rather than the documented password position). Remove this rewrite and its step-scoped token environment.
          git config --global url."https://$($env:GH_TOKEN)@github.com/".insteadOf "https://github.com/"
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/promote-shipped-apis.yml Outdated
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed workflow changes have no unresolved approval-blocking issues.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 0d70d4b Sep 4, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants