Skip to content

feat: conda support#657

Merged
mxschmitt merged 3 commits into
microsoft:masterfrom
kumaraditya303:feature/conda
May 11, 2021
Merged

feat: conda support#657
mxschmitt merged 3 commits into
microsoft:masterfrom
kumaraditya303:feature/conda

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

Fixes #257

@mxschmitt

Copy link
Copy Markdown
Contributor

Status-update: waiting for credentials on our side.

Comment thread meta.yaml
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/ci.yml Outdated

@mxschmitt mxschmitt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/ci.yml
Comment thread meta.yaml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/publish.yml
Comment thread .github/workflows/ci.yml
@mxschmitt

mxschmitt commented May 11, 2021

Copy link
Copy Markdown
Contributor

Would also be nice if you could add some docs, I thought about a badge (ref: https://shields.io):

Conda

(with a link to anaconda.org)

and maybe under usage a code block for anaconda with

conda config --add channels conda-forge
conda install -c microsoft playwright

.

@kumaraditya303

Copy link
Copy Markdown
Contributor Author

Will add docs in a following PR.

@kumaraditya303 kumaraditya303 requested a review from mxschmitt May 11, 2021 10:00
@zooba

zooba commented May 11, 2021

Copy link
Copy Markdown
Member

I thought about a badge

Not sure if you need to be logged in to see it, but there are badges provided by anaconda.org at https://anaconda.org/Microsoft/playwright/badges

@mxschmitt mxschmitt merged commit 2c5687a into microsoft:master May 11, 2021
mxschmitt pushed a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the conda package manager for installation

4 participants