fixed Visually out of place drop down in pull requests views with Safari#3244
fixed Visually out of place drop down in pull requests views with Safari#3244Yash621 wants to merge 6 commits into
Conversation
|
Looks like we lost some of the original styling (the arrow on the right of the select is gone):
The select now also has rounded corners, which isn't consistent with other selects in VS Code: The colors look good though. Do you know if there's a way to fix the lost styling? |
|
@alexr00 sure , i would look into it and get back to you ! |
alexr00
left a comment
There was a problem hiding this comment.
Thanks for the update! I'm seeing some style discrepancies, which I've left a comment on.
You can always push more commits to this PR and it will update, instead of creating a new PR each time :).
|
@alexr00 I have tried to fix the styling but i am not getting like why the arrows have disappeared ,can you guide me on this ? |
|
@Yash621 I don't know why the arrows have disappeared off the top of my head so I don't have any guidance on this. I can do some digging into this later! |
|
@alexr00 Please see once ,and let me know as I have tried some approches but none is working so please let me know :) |
|
@alexr00 did you got any time to do some digging on why the arrows have disappeared ? |
|
@Yash621 not yet! |
|
I believe it is due to Is this still a problem looking to be solved? I'd be interested in working on it if so :) |
|
Closing due to lack of activity. @Yash621 if you're still planning to work on this please let me know and I'll reopen! |
This PR is with respect to issue #2426
@alexr00 I have removed all the changes that are not related to fixing the bug,please review them.
let me know if any changes are required :)