Add guessableName to GB18030 encoding#300315
Open
frg2089 wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
jschardetoften misidentifies GB18030 encoded files as GB2312 due to their backward compatibility. However, this causes significant issues because GB18030 supports the full Unicode range (similar to UTF-8), whereas GB2312 does not.Reproduction: If a text file containing characters like
🌟𠀚〇𡌴鉏is saved in GB18030, jschardet may detect it as GB2312. Upon reading the file with this incorrect encoding, these unsupported characters result in garbled text (e.g.,�9�9�2�2〇�5�2鉏).Close: #248513