Reduce IChatSessionsService interface size#300587
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 10, 2026
Merged
Conversation
Make everything go through the contributions instead off having separate getters for each value
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the surface area of IChatSessionsService by removing per-field getters (icon/welcome/placeholder) and routing consumers through resolved chat session contributions instead.
Changes:
- Introduces
ResolvedChatSessionsExtensionPointand updatesIChatSessionsServiceAPIs to return resolved contributions (including a resolvedicon). - Refactors
ChatSessionsServiceto resolve contribution icons (ThemeIcon or theme-specific URI) on demand, and removes the old per-session-type caches/getters. - Updates UI/action consumers to read
icon, welcome fields, and placeholder directly from the resolved contribution.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts | Updates mock service to return resolved contributions (needs icon parsing aligned with production). |
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Adds ResolvedChatSessionsExtensionPoint and shrinks IChatSessionsService interface. |
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts | Adjusts agent lock call to use sessionType. |
| src/vs/workbench/contrib/chat/browser/widgetHosts/editor/chatEditorInput.ts | Uses contribution’s resolved icon instead of removed icon getter. |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Reads welcome/title/message/placeholder from resolved contribution instead of removed getters. |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Implements resolved contribution/icon logic and removes cached per-type getter maps. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsModel.ts | Updates contribution map typing to the resolved contribution type. |
| src/vs/workbench/contrib/chat/browser/actions/chatContinueInAction.ts | Updates action plumbing to accept the resolved contribution type. |
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to clean up this service interface by having everything go through the contributions instead off having separate getters for each value