Skip to content

Replacing calls to Exception#printStackTrace() with Java logging. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 3 commits into from
Dec 7, 2014
Merged

Replacing calls to Exception#printStackTrace() with Java logging. #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
407caae
Replacing calls to `Exception#printStackTrace()` with Java logging.
Oct 2, 2014
d952d28
Replacing some tabs with spaces for consistency.
Oct 2, 2014
ec4eb62
Use Log#log(Level, String, Throwable).
Oct 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/msgpack/template/builder/JavassistTemplateBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ public JavassistTemplateBuilder(TemplateRegistry registry, ClassLoader cl) {
appended = true;
}
} catch (SecurityException e) {
LOG.fine("Cannot append a search path of classloader");
e.printStackTrace();
if (LOG.isLoggable(Level.WARNING)) {
LOG.log(Level.WARNING, "Cannot append a search path of classloader", e);
}
}
if (!appended) {
pool.appendSystemPath();
Expand Down
34 changes: 20 additions & 14 deletions src/main/java/org/msgpack/template/builder/TemplateBuilderChain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,19 @@
import java.lang.reflect.Type;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

import org.msgpack.template.TemplateRegistry;
import org.msgpack.util.android.DalvikVmChecker;

public class TemplateBuilderChain {
private static final String JAVASSIST_TEMPLATE_BUILDER_CLASS_NAME =
"org.msgpack.template.builder.JavassistTemplateBuilder";
private static final String REFLECTION_TEMPLATE_BUILDER_CLASS_NAME =
"org.msgpack.template.builder.ReflectionTemplateBuilder";
private static final Logger LOG = Logger.getLogger(TemplateBuilderChain.class.getName());

private static final String JAVASSIST_TEMPLATE_BUILDER_CLASS_NAME =
"org.msgpack.template.builder.JavassistTemplateBuilder";
private static final String REFLECTION_TEMPLATE_BUILDER_CLASS_NAME =
"org.msgpack.template.builder.ReflectionTemplateBuilder";

private static boolean enableDynamicCodeGeneration() {
return !DalvikVmChecker.isDalvikVm() &&
Expand Down Expand Up @@ -74,16 +78,18 @@ protected void reset(final TemplateRegistry registry, final ClassLoader cl) {
templateBuilders.add(new ReflectionBeansTemplateBuilder(registry));
}

private static TemplateBuilder createForceTemplateBuilder(String className,
TemplateRegistry registry, ClassLoader cl) {
try {
Class<?> c = (Class<?>) Class.forName(className);
Constructor<?> cons = c.getConstructor(TemplateRegistry.class,
ClassLoader.class);
return (TemplateBuilder) cons.newInstance(registry, cl);
} catch (Exception e) {
e.printStackTrace();
}
private static TemplateBuilder createForceTemplateBuilder(String className,
TemplateRegistry registry, ClassLoader cl) {
try {
Class<?> c = (Class<?>) Class.forName(className);
Constructor<?> cons = c.getConstructor(TemplateRegistry.class,
ClassLoader.class);
return (TemplateBuilder) cons.newInstance(registry, cl);
} catch (Exception e) {
if (LOG.isLoggable(Level.WARNING)) {
LOG.log(Level.WARNING, "Failed to create a TemplateBuilder reflectively", e);
}
}
return new ReflectionTemplateBuilder(registry, cl);
}

Expand Down