True that chakrashim is a dependency, but it doesn't come from any repo. is updated directly in this repo. May be if we move chakrashim in its own repo we can move these contribution guidelines with it. Till then we can have it here, if someone wants to update shim.

'Chakracore' is a dependency that directly come as it is from Microsoft/Chakracore and we definitely don't want it's contribution guidelines here.

Sent from Outlook Mobilehttps://aka.ms/blhgte

From: Alexis Campailla
Sent: Friday, February 19, 07:22
Subject: Re: [node-chakracore] Update contribution guidelines for javascript and C++ files (#28)
To: nodejs/node-chakracore
Cc: Kunal Pathak

Isn't code in chakrashim considered a dependency that we take as a whole and don't modify here? I feel that it if those conventions should be documented it would be in the httpshttps://github.com/Microsoft/ChakraCore://https://github.com/Microsoft/ChakraCoregithub.comhttps://github.com/Microsoft/ChakraCore/Microsoft/https://github.com/Microsoft/ChakraCoreChakraCorehttps://github.com/Microsoft/ChakraCore repo.

Reply to this email directly or view it on #28 (comment) GitHubhttps://github.com//issues/28#issuecomment-186258170.

Uh oh!

Uh oh!

Update contribution guidelines for javascript and C++ files #28

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions