Repository navigation
Tooling is confused by commits with title only #1058
Description
Commit-queue has failed to land nodejs/node#61806. This has two commits, the first of which (a96cf6342b435d70772d66eb7e1d266aeee39a4e) is a title only commit:
commit 4fffe5ebc3c4f3d59deea601afa025e3f6e537c0 (HEAD -> enable-temporal, origin/enable-temporal)
Author: Richard Lau <richard.lau@ibm.com>
Date: Fri Apr 10 17:05:24 2026 +0000
build: enable Temporal by default
Enabling Temporal support requires `cargo` and `rustc`, which are new
build toolchain requirements.
Add a `--v8-disable-temporal-support` option to `configure.py` to
explicitly opt-out of Temporal support (i.e. no need for Rust).
If the existing `--v8-enable-temporal-support` option is not explicitly
passed to `configure.py`:
- Attempt to detect `cargo` and `rustc`.
- If neither `cargo` and `rustc` are detected, print a warning and
disable Temporal support.
- If both `cargo` and `rustc` are detected, enable Temporal support.
If `--v8-enable-temporal-support` is passed to `configure.py`, then
the build will error and stop if `cargo` and/or `rustc` are not
detected.
To avoid ambiguity, `configure.py` will error and stop if both
`--v8-disable-temporal-support` and `--v8-enable-temporal-support` are
used.
Signed-off-by: Richard Lau <richard.lau@ibm.com>
commit a96cf6342b435d70772d66eb7e1d266aeee39a4e
Author: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Mon Apr 6 21:29:57 2026 +0200
build,win: fix Temporal build
This has confused the landing session. I think what is happening is that the PR-URL metadata is being appended but without a blank line to separate it from the title.
Commit Queue failed
- Loading data for nodejs/node/pull/61806
✔ Done loading data for nodejs/node/pull/61806
----------------------------------- PR info ------------------------------------
Title build: enable Temporal by default (#61806)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch richardlau:enable-temporal -> nodejs:main
Labels semver-major, build, notable-change, author ready, needs-ci, commit-queue-rebase
Commits 2
- build,win: fix Temporal build
- build: enable Temporal by default
Committers 1
- Richard Lau <richard.lau@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/61806
Fixes: https://github.com/nodejs/node/issues/57127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61806
Fixes: https://github.com/nodejs/node/issues/57127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Fri, 13 Feb 2026 18:36:01 GMT
✔ Approvals: 9
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61806#pullrequestreview-3799356614
✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61806#pullrequestreview-3801982887
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/61806#pullrequestreview-3801994015
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61806#pullrequestreview-4093347278
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61806#pullrequestreview-3831874154
✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/61806#pullrequestreview-3845221881
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/61806#pullrequestreview-3971773184
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61806#pullrequestreview-3971843332
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61806#pullrequestreview-4092102105
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-04-10T17:16:30Z: https://ci.nodejs.org/job/node-test-pull-request/72610/
- Querying data for job/node-test-pull-request/72610/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 61806
From https://github.com/nodejs/node
* branch refs/pull/61806/merge -> FETCH_HEAD
✔ Fetched commits as f01905ac0140..4fffe5ebc3c4
--------------------------------------------------------------------------------
[main 58082e5a78] build,win: fix Temporal build
Author: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Mon Apr 6 21:29:57 2026 +0200
3 files changed, 133 insertions(+), 18 deletions(-)
create mode 100644 deps/crates/cargo_build.py
[main c71e0ae5fe] build: enable Temporal by default
Author: Richard Lau <richard.lau@ibm.com>
Date: Fri Apr 10 17:05:24 2026 +0000
1 file changed, 61 insertions(+), 20 deletions(-)
✔ Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:359) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
PR-URL: https://github.com/nodejs/node/pull/61806
Fixes: https://github.com/nodejs/node/issues/57127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 1a87984eb4] PR-URL: https://github.com/nodejs/node/pull/61806 Fixes: https://github.com/nodejs/node/issues/57127 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Author: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Mon Apr 6 21:29:57 2026 +0200
3 files changed, 133 insertions(+), 18 deletions(-)
create mode 100644 deps/crates/cargo_build.py
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
build: enable Temporal by default
Enabling Temporal support requires `cargo` and `rustc`, which are new
build toolchain requirements.
Add a `--v8-disable-temporal-support` option to `configure.py` to
explicitly opt-out of Temporal support (i.e. no need for Rust).
If the existing `--v8-enable-temporal-support` option is not explicitly
passed to `configure.py`:
- Attempt to detect `cargo` and `rustc`.
- If neither `cargo` and `rustc` are detected, print a warning and
disable Temporal support.
- If both `cargo` and `rustc` are detected, enable Temporal support.
If `--v8-enable-temporal-support` is passed to `configure.py`, then
the build will error and stop if `cargo` and/or `rustc` are not
detected.
To avoid ambiguity, `configure.py` will error and stop if both
`--v8-disable-temporal-support` and `--v8-enable-temporal-support` are
used.
Signed-off-by: Richard Lau <richard.lau@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/61806
Fixes: https://github.com/nodejs/node/issues/57127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD b9c16571a1] build: enable Temporal by default
Author: Richard Lau <richard.lau@ibm.com>
Date: Fri Apr 10 17:05:24 2026 +0000
1 file changed, 61 insertions(+), 20 deletions(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
✖ 1a87984eb462d0fcb28c93bbfaad60535f056267
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:7 Valid fixes URL. fixes-url
✖ 1:0 blank line expected after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✖ 0:0 Commit must have a PR-URL. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Invalid subsystem: "PR-URL" subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✔ b9c16571a17e2eb6ade5abd04b1b0d46c3cce4df
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 24:7 Valid fixes URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 23:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`
Activity
aduh95 commentedon Apr 13, 2026
I'll be writing some tests, the current workflow for making changes is too brittle (it's the second time in a row one of my "fixes" end up breaking something else)