Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
fa105ab
buffer: little improve for Buffer.concat method
JacksonTian Apr 16, 2015
1ab65e4
src: fix NODE_DEPRECATED macro
bnoordhuis Apr 29, 2015
3c9f63f
src: fix deprecation warnings
bnoordhuis Apr 29, 2015
a76b6ba
gitignore: ignore xcode workspaces and projects
r-52 Apr 29, 2015
91da332
build: Use option groups in configure output
jbergstroem Apr 27, 2015
f6d7de1
build: move --with-intl to intl optgroup
jbergstroem May 12, 2015
c5d7c7e
stream_base: dispatch reqs in the stream impl
indutny Apr 29, 2015
592230a
tls: use `SSL_set_cert_cb` for async SNI/OCSP
indutny Apr 18, 2015
908643d
node: improve nextTick performance
mscdex May 1, 2015
26760a9
net: ensure Write/ShutdownWrap references handle
indutny May 2, 2015
dedddb7
tls_wrap: Unlink TLSWrap and SecureContext objects
ChALkeR May 1, 2015
6568dc9
src: fix -Wmissing-field-initializers warning
bnoordhuis May 4, 2015
a2b6650
async-wrap: don't call init callback unnecessarily
trevnorris May 4, 2015
c8b05e4
async-wrap: pass PROVIDER as first arg to init
trevnorris May 4, 2015
a703e07
async-wrap: set flags using functions
trevnorris May 4, 2015
54ae094
async-wrap: remove before/after calls in init
trevnorris May 4, 2015
d90eadc
src: fix NODE_DEPRECATED macro with old compilers
bnoordhuis May 5, 2015
df389c6
src: fix pedantic cpplint whitespace warnings
bnoordhuis May 6, 2015
46561fc
js_stream: fix buffer index in DoWrite
May 6, 2015
8651ecc
deps: update libuv to 1.5.0
saghul May 6, 2015
98b1109
src: export the ParseEncoding function on Windows
ivan May 3, 2015
e628b19
install: fix NameError
thefourtheye May 5, 2015
e42dcc2
src: add type check to v8.setFlagsFromString()
r-52 May 7, 2015
ebc671b
cluster: disconnect event not emitted correctly
Olegas Apr 2, 2015
367e221
tools: replace closure-linter with eslint
yosuke-furukawa Apr 28, 2015
edb4cb6
lib: fix eslint styles
yosuke-furukawa Apr 28, 2015
82a5dab
tools: remove closure_linter to eslint on windows
May 12, 2015
ecb2436
tools: set eslint comma-spacing to 'warn'
silverwind May 11, 2015
91a9c6d
tools: make eslint work on subdirectories
silverwind May 12, 2015
c212f8e
readline: turn emitKeys into a streaming parser
rlidwka May 3, 2015
e05afd7
dgram: call send callback asynchronously
yosuke-furukawa Apr 1, 2015
e7427ae
test: fix infinite loop detection
May 12, 2015
da99a94
tls: update default ciphers to use gcm and aes128
May 8, 2015
05e61c7
build: re-enable V8 snapshots
trevnorris May 8, 2015
8ebdb29
deps: sync with upstream bagder/c-ares@bba4dc5
bnoordhuis May 11, 2015
570f2a3
deps: provide TXT chunk info in c-ares
indutny Mar 27, 2014
887db51
src,deps: replace LoadLibrary by LoadLibraryW
zcbenz Dec 31, 2014
69bc061
events: provide better error message for unhandled error
evanlucas May 7, 2015
3416e93
tools: refactor `make test-npm` into test-npm.sh
Fishrock123 May 7, 2015
c7eab79
build: use backslashes for paths on windows
jbergstroem May 13, 2015
df9aac8
src: fix preload when used with prior flags
yosuke-furukawa May 13, 2015
0e9be82
tls: fix tls handshake check in ssl error
May 8, 2015
4ba3d68
tls_wrap: fix error cb when fatal TLS Alert recvd
May 8, 2015
575738b
core: set PROVIDER type as Persistent class id
trevnorris May 18, 2015
9f8a3a4
test: enable linting for tests
silverwind May 19, 2015
f8e5eaa
tls: make server not use DHE in less than 1024bits
May 20, 2015
0c6a548
util: speed up common case of formatting string
ChALkeR May 20, 2015
cb3326f
build: refactor pkg-config for shared libraries
jbergstroem May 4, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: Use option groups in configure output
Minor edits to current build flags and its help texts as well
as grouping shared and i18n options into separate option groups.

Also, validate i18n default/logic similar to how we treat other
options. `--download` isn't really intl-specific but is only used
for that purpose which is why it's grouped similarly.

PR-URL: #1533
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Steven R. Loomis <srl@icu-project.org>
  • Loading branch information
jbergstroem authored and Fishrock123 committed May 19, 2015
commit 91da33233f3ab997ba1444dcd79a0acb74ac124d
78 changes: 45 additions & 33 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ valid_arm_float_abi = ('soft', 'softfp', 'hard')
valid_mips_arch = ('loongson', 'r1', 'r2', 'r6', 'rx')
valid_mips_fpu = ('fp32', 'fp64', 'fpxx')
valid_mips_float_abi = ('soft', 'hard')
valid_intl_modes = ('none', 'small-icu', 'full-icu', 'system-icu')

# create option groups
shared_optgroup = optparse.OptionGroup(parser, "Shared libraries",
"Flags that allows you to control whether you want to build against "
"built-in dependencies or its shared representations. If necessary, "
"provide multiple libraries with comma.")
intl_optgroup = optparse.OptionGroup(parser, "Internationalization",
"Flags that lets you enable i18n features in io.js as well as which "
"library you want to build against.")

# Options should be in alphabetical order but keep --prefix at the top,
# that's arguably the one people will be looking for most.
Expand Down Expand Up @@ -78,90 +88,92 @@ parser.add_option("--openssl-no-asm",
dest="openssl_no_asm",
help="Do not build optimized assembly for OpenSSL")

parser.add_option('--shared-http-parser',
shared_optgroup.add_option('--shared-http-parser',
action='store_true',
dest='shared_http_parser',
help='link to a shared http_parser DLL instead of static linking')

parser.add_option('--shared-http-parser-includes',
shared_optgroup.add_option('--shared-http-parser-includes',
action='store',
dest='shared_http_parser_includes',
help='directory containing http_parser header files')

parser.add_option('--shared-http-parser-libname',
shared_optgroup.add_option('--shared-http-parser-libname',
action='store',
dest='shared_http_parser_libname',
default='http_parser',
help='alternative lib name to link to [default: %default]')

parser.add_option('--shared-http-parser-libpath',
shared_optgroup.add_option('--shared-http-parser-libpath',
action='store',
dest='shared_http_parser_libpath',
help='a directory to search for the shared http_parser DLL')

parser.add_option('--shared-libuv',
shared_optgroup.add_option('--shared-libuv',
action='store_true',
dest='shared_libuv',
help='link to a shared libuv DLL instead of static linking')

parser.add_option('--shared-libuv-includes',
shared_optgroup.add_option('--shared-libuv-includes',
action='store',
dest='shared_libuv_includes',
help='directory containing libuv header files')

parser.add_option('--shared-libuv-libname',
shared_optgroup.add_option('--shared-libuv-libname',
action='store',
dest='shared_libuv_libname',
default='uv',
help='alternative lib name to link to [default: %default]')

parser.add_option('--shared-libuv-libpath',
shared_optgroup.add_option('--shared-libuv-libpath',
action='store',
dest='shared_libuv_libpath',
help='a directory to search for the shared libuv DLL')

parser.add_option('--shared-openssl',
shared_optgroup.add_option('--shared-openssl',
action='store_true',
dest='shared_openssl',
help='link to a shared OpenSSl DLL instead of static linking')

parser.add_option('--shared-openssl-includes',
shared_optgroup.add_option('--shared-openssl-includes',
action='store',
dest='shared_openssl_includes',
help='directory containing OpenSSL header files')

parser.add_option('--shared-openssl-libname',
shared_optgroup.add_option('--shared-openssl-libname',
action='store',
dest='shared_openssl_libname',
default='crypto,ssl',
help='alternative lib name to link to [default: %default]')

parser.add_option('--shared-openssl-libpath',
shared_optgroup.add_option('--shared-openssl-libpath',
action='store',
dest='shared_openssl_libpath',
help='a directory to search for the shared OpenSSL DLLs')

parser.add_option('--shared-zlib',
shared_optgroup.add_option('--shared-zlib',
action='store_true',
dest='shared_zlib',
help='link to a shared zlib DLL instead of static linking')

parser.add_option('--shared-zlib-includes',
shared_optgroup.add_option('--shared-zlib-includes',
action='store',
dest='shared_zlib_includes',
help='directory containing zlib header files')

parser.add_option('--shared-zlib-libname',
shared_optgroup.add_option('--shared-zlib-libname',
action='store',
dest='shared_zlib_libname',
default='z',
help='alternative lib name to link to [default: %default]')

parser.add_option('--shared-zlib-libpath',
shared_optgroup.add_option('--shared-zlib-libpath',
action='store',
dest='shared_zlib_libpath',
help='a directory to search for the shared zlib DLL')

parser.add_option_group(shared_optgroup)

# TODO document when we've decided on what the tracing API and its options will
# look like
parser.add_option('--systemtap-includes',
Expand Down Expand Up @@ -225,33 +237,38 @@ parser.add_option('--with-etw',
dest='with_etw',
help='build with ETW (default is true on Windows)')

parser.add_option('--download',
parser.add_option('--with-intl',
action='store',
dest='download_list',
help=nodedownload.help())
dest='with_intl',
default='none',
choices=valid_intl_modes,
help='Intl mode (valid choices: {0}) [default: %default]'.format(
', '.join(valid_intl_modes)))

parser.add_option('--with-icu-path',
intl_optgroup.add_option('--with-icu-path',
action='store',
dest='with_icu_path',
help='Path to icu.gyp (ICU i18n, Chromium version only.)')

parser.add_option('--with-icu-locales',
intl_optgroup.add_option('--with-icu-locales',
action='store',
dest='with_icu_locales',
default='root,en',
help='Comma-separated list of locales for "small-icu". "root" is assumed. '
'[default: %default]')

parser.add_option('--with-intl',
action='store',
dest='with_intl',
help='Intl mode: none, full-icu, small-icu [default: none]')

parser.add_option('--with-icu-source',
intl_optgroup.add_option('--with-icu-source',
action='store',
dest='with_icu_source',
help='Intl mode: optional local path to icu/ dir, or path/URL of icu source archive.')

intl_optgroup.add_option('--download',
action='store',
dest='download_list',
help=nodedownload.help())

parser.add_option_group(intl_optgroup)

parser.add_option('--with-perfctr',
action='store_true',
dest='with_perfctr',
Expand Down Expand Up @@ -812,7 +829,7 @@ def configure_intl(o):
with_intl = options.with_intl
with_icu_source = options.with_icu_source
have_icu_path = bool(options.with_icu_path)
if have_icu_path and with_intl:
if have_icu_path and with_intl != 'none':
print 'Error: Cannot specify both --with-icu-path and --with-intl'
sys.exit(1)
elif have_icu_path:
Expand Down Expand Up @@ -850,11 +867,6 @@ def configure_intl(o):
# use the "system" .gyp
o['variables']['icu_gyp_path'] = 'tools/icu/icu-system.gyp'
return
else:
print 'Error: unknown value --with-intl=%s' % with_intl
sys.exit(1)
# Note: non-ICU implementations could use other 'with_intl'
# values.

# this is just the 'deps' dir. Used for unpacking.
icu_parent_path = os.path.join(root_dir, 'deps')
Expand Down