Skip to content

assert: accept regular expressions to validate#20485

Closed
BridgeAR wants to merge 3 commits intonodejs:masterfrom
BridgeAR:assert-add-reg-exp
Closed

assert: accept regular expressions to validate#20485
BridgeAR wants to merge 3 commits intonodejs:masterfrom
BridgeAR:assert-add-reg-exp

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented May 2, 2018

This makes sure regular expressions on validation objects validate
against strings when used with assert.throws and assert.rejects.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BridgeAR @vsemozhetbyt @BeyondEvil @jasnell @targos @nodejs-github-bot