Skip to content

doc: add build wg info to releases.md #21275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maclover7 wants to merge 3 commits into from
Closed

doc: add build wg info to releases.md #21275

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5511b21
doc: add build wg info to releases.md
maclover7 Jun 12, 2018
73374c4
[squash] add "how"
maclover7 Jun 12, 2018
3506130
[squash] nits
maclover7 Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] add "how"
  • Loading branch information
@maclover7
maclover7 committed Jun 12, 2018
commit 73374c41c510c6571eaea8692c293dc41495ee77
5 changes: 5 additions & 0 deletions doc/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ least twenty-four hours in advance of the expected release. Coordinating with
Build is essential to make sure that the CI works, release files are published,
and the release blog post is available on the project website.

Build can be contacted best by opening up an issue on the [issue tracker][],
Copy link
Copy Markdown
Member

@Trott Trott Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue tracker -> the Build issue tracker?

and by posting in `#node-build` on [webchat.freenode.net][].

When preparing a security release, contact Build at least forty-eight hours in
Copy link
Copy Markdown
Member

@Trott Trott Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forty-eight hours -> two business days?

Copy link
Copy Markdown
Member

@benjamingr benjamingr Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes though they are tricky - maybe week day since there might be holidays based on locale?

advance of the expected release. To ensure that the security patch(es) can be
properly tested, run a `node-test-pull-request` job against the `master` branch
Expand Down Expand Up @@ -531,4 +534,6 @@ Close your release proposal PR and remove the proposal branch.
_In whatever form you do this..._

[CI lockdown procedure]: https://github.com/nodejs/build/blob/master/doc/jenkins-guide.md#restricting-access-for-security-releases
[issue tracker]: https://github.com/nodejs/build/issues/new
[nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/master/scripts/release-post.js
[webchat.freenode.net]: https://webchat.freenode.net/