Skip to content

test_runner: support passing globs#47653

Closed
MoLow wants to merge 2 commits intonodejs:mainfrom
MoLow:use-minimatch
Closed

test_runner: support passing globs#47653
MoLow wants to merge 2 commits intonodejs:mainfrom
MoLow:use-minimatch

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Apr 21, 2023 •
edited
Loading

a followup for #47499
this includes a lean implementation of https://github.com/isaacs/node-glob on top of minimatch (added at #47499)

this is marked as semver-major PRs that contain breaking changes and should be released in the next major version. since a couple of edge cases will produce a different list of tests such as file names containing *

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb requested changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

+1 more reviewer

@isaacs isaacs isaacs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using node:test with Custom ESM Loaders