Skip to content

[v24.x] deps: V8: cherry-pick 3d750c2aa9ef#58750

Closed
targos wants to merge 1 commit intonodejs:v24.x-stagingfrom
targos:v8-fix-erm-24
Closed

[v24.x] deps: V8: cherry-pick 3d750c2aa9ef#58750
targos wants to merge 1 commit intonodejs:v24.x-stagingfrom
targos:v8-fix-erm-24

Conversation

@targos
Copy link
Member

@targos targos commented Jun 18, 2025

Original commit message:

[explicit-resource-management] Fix disposal for context variable

This CL adds disposable variable when `using` or `await_using` is
referenced by the closure.

Bug: 409478039
Change-Id: I162915ea53f5b9f17892fa88d288a94bd50cc46f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6444591
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99746}

Refs: v8/v8@3d750c2
Closes: #58744

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Jun 18, 2025
@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jun 18, 2025
@targos targos mentioned this pull request Jun 18, 2025
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67519/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6615/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6615/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6615/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67563/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67795/

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025
@targos
Copy link
Member Author

targos commented Jul 3, 2025

Too old CI to be resumed.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67803/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6642/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6642/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6642/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67823/

@targos
Copy link
Member Author

targos commented Jul 4, 2025

Had to rebase and update the embedder string.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67832/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67841/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67844/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67865/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67868/

@Renegade334
Copy link
Member

Renegade334 commented Jul 17, 2025

Needs another rebase!

@targos
deps: V8: cherry-pick 3d750c2aa9ef
da292ab 
Original commit message:

    [explicit-resource-management] Fix disposal for context variable

    This CL adds disposable variable when `using` or `await_using` is
    referenced by the closure.

    Bug: 409478039
    Change-Id: I162915ea53f5b9f17892fa88d288a94bd50cc46f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6444591
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#99746}

Refs: v8/v8@3d750c2
@targos
Copy link
Member Author

targos commented Jul 17, 2025

Rebased.

targos
targos commented Jul 17, 2025
View reviewed changes
common.gypi
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.17',
'v8_embedder_string': '-node.21',
Copy link
Member Author

@targos targos Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to correct the number after 573171d was cherry-picked incorrectly.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2025

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: V8: cherry-pick 3d750c2aa9ef
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/16389468074

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68031/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6665/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6665/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6665/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68097/

@targos
Copy link
Member Author

targos commented Jul 23, 2025

Landed in 2a5f35b

@targos targos closed this Jul 23, 2025
@targos targos deleted the v8-fix-erm-24 branch July 23, 2025 07:11
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos @nodejs-github-bot @Renegade334 @richardlau