crypto: reject ML-KEM/ML-DSA PKCS#8 import without seed in SubtleCrypto#62218
Open
panva wants to merge 1 commit intonodejs:mainfrom
Open
crypto: reject ML-KEM/ML-DSA PKCS#8 import without seed in SubtleCrypto#62218panva wants to merge 1 commit intonodejs:mainfrom
panva wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Reject importing ML-KEM and ML-DSA PKCS#8 private keys that do not include a seed, throwing NotSupportedError. Also add tests for importing PKCS#8 keys with a mismatched expanded key. Refs: https://redirect.github.com/WICG/webcrypto-modern-algos/pull/34
e99ae40 to
dc1212a
Compare
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62218 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 676 676
Lines 206451 206477 +26
Branches 39529 39533 +4
=======================================
+ Hits 185139 185165 +26
+ Misses 13451 13443 -8
- Partials 7861 7869 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject importing ML-KEM and ML-DSA PKCS#8 private keys that do not include a seed, throwing NotSupportedError.
Also add tests for importing PKCS#8 keys with a mismatched expanded key.
Refs: https://redirect.github.com/WICG/webcrypto-modern-algos/pull/34