test: use heapdump test for SecureContext memory tracking - #64344
Open
mertcanaltin wants to merge 3 commits into
Open
test: use heapdump test for SecureContext memory tracking#64344mertcanaltin wants to merge 3 commits into
mertcanaltin wants to merge 3 commits into
Conversation
Member
Author
|
hey @joyeecheung I applied your last sugesstions (#62689 (comment), #62689 (comment)) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64344 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.02%
==========================================
Files 771 771
Lines 265169 265169
Branches 50368 50358 -10
==========================================
- Hits 239152 239122 -30
- Misses 16958 17015 +57
+ Partials 9059 9032 -27 🚀 New features to boost your workflow:
|
mertcanaltin
force-pushed
the
fix/remove-cctest-memory-tracking
branch
from
August 20, 2026 10:24
b76e1c1 to
342ac8e
Compare
jasnell
approved these changes
Sep 8, 2026
Member
|
@mertcanaltin ... can I ask you to rebase this before I kick off the CI run |
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
mertcanaltin
force-pushed
the
fix/remove-cctest-memory-tracking
branch
from
September 8, 2026 17:26
342ac8e to
485fd25
Compare
Member
Author
Thanks, I did it |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cctest with a heap snapshot test for SecureContext memory tracking.
Refs: #59051
@joyeecheung #59051 (comment)