Skip to content

typings: add stream_pipe internal binding types - #65664

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
leah-1ee:typings-stream-pipe
Sep 6, 2026
Merged

typings: add stream_pipe internal binding types#65664
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
leah-1ee:typings-stream-pipe

Conversation

@leah-1ee

Copy link
Copy Markdown
Contributor

Add typings for the stream_pipe internal binding.

Changes:

  • Added typings/internalBinding/stream_pipe.d.ts
  • Added stream_pipe to InternalBindingMap
  • Typed the StreamPipe class: unpipe(), start(), isClosed(),
    pendingWrites(), and the onunpipe/oncomplete callbacks

Add a StreamPipeBinding declaration for internalBinding('stream_pipe')
and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
Copilot AI lite review requested due to automatic review settings August 30, 2026 08:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Aug 30, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 30, 2026
@nodejs-github-bot nodejs-github-bot added the lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. label Sep 1, 2026
@nodejs-github-bot
nodejs-github-bot merged commit f16b556 into nodejs:main Sep 6, 2026
31 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in f16b556

@nodejs-github-bot nodejs-github-bot removed commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. labels Sep 6, 2026
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
Add a StreamPipeBinding declaration for internalBinding('stream_pipe')
and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65664
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
Add a StreamPipeBinding declaration for internalBinding('stream_pipe')
and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65664
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants