crypto: avoid network access loading system CAs - #65765
Open
chrmarti wants to merge 3 commits into
Open
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65765 +/- ##
==========================================
+ Coverage 89.95% 90.06% +0.10%
==========================================
Files 757 769 +12
Lines 258080 261316 +3236
Branches 48933 49629 +696
==========================================
+ Hits 232168 235342 +3174
- Misses 16971 17029 +58
- Partials 8941 8945 +4
🚀 New features to boost your workflow:
|
Use the purpose-neutral Basic X.509 policy when enumerating macOS system certificates. Verify that enumeration does not fetch AIA or OCSP resources. Assisted-by: AI coding assistant Signed-off-by: Christof Marti <chrmarti@microsoft.com>
Replace runtime certificate generation with checked-in fixtures and Makefile targets for the macOS system CA network test. Assisted-by: AI coding assistant Signed-off-by: Christof Marti <chrmarti@microsoft.com>
chrmarti
force-pushed
the
chrmarti/disable-system-ca-network-fetch
branch
from
September 4, 2026 07:24
7e40c26 to
a5c25cf
Compare
Keep the existing SSL client policy and explicitly disable network access. This avoids AIA and revocation requests without changing which certificates pass the fallback evaluation. Assisted-by: AI coding assistant Signed-off-by: Christof Marti <chrmarti@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the existing macOS SSL client policy when filtering system certificates, but disable network access with
SecTrustSetNetworkFetchAllowedbeforeSecTrustEvaluateWithError. This prevents AIA issuer downloads and revocation requests while building the system CA cache without changing which certificates pass the fallback evaluation.Add an opt-in macOS regression test with pinned certificates and a local AIA/OCSP responder. The test verifies that Node.js system CA enumeration makes no requests, while macOS certificate validation confirms that the generated endpoints are reachable.
Fixes: #63313
Tests:
make -j8test/system-ca/test-*.jsandtest-*.mjsfilesmake lint-jsmake lint-cpp