Skip to content

Fixes highlighting for finally in certain cases.#1230

Merged
amadeus merged 1 commit into
pangloss:masterfrom
thomasstep:fix-optional-catch-parens
Mar 9, 2021
Merged

Fixes highlighting for finally in certain cases.#1230
amadeus merged 1 commit into
pangloss:masterfrom
thomasstep:fix-optional-catch-parens

Conversation

@thomasstep

Copy link
Copy Markdown
Contributor

jsCatch can be followed by jsParenCatch or jsTryCatchBlock. A catch can either be followed directly by a block or optionally have parens for an error parameter. The original issue noticed that in the code

try {} catch {} finally {}

finally was not realized as a keyword. This PR fixes that by allowing the nextgroup to be either parens or a block.

@thomasstep

Copy link
Copy Markdown
Contributor Author

Fixes #1222

@thomasstep thomasstep changed the title Fixes #1222 Fixes highlighting for finally in certain cases. Mar 9, 2021
@amadeus

amadeus commented Mar 9, 2021

Copy link
Copy Markdown
Collaborator

Hah - i totally fixed this locally and forgot to push it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants