Add host constraints to mix phx.routes output - #6594
Open
t3chw wants to merge 1 commit into
Open
Conversation
SteffenDE
approved these changes
Feb 21, 2026
josevalim
reviewed
Feb 21, 2026
| Map.put(route, :label, nested_route.label) | ||
| route | ||
| |> Map.put(:label, nested_route.label) | ||
| |> Map.put(:hosts, Map.get(nested_route, :hosts, route.hosts)) |
Member
There was a problem hiding this comment.
I think we need a test for this part of the code.
In particular, if both the parent and the child router define a host, what would happen? We would probably check the host in both cases, so it is not like one would win over the other?
There was a problem hiding this comment.
@t3chw I think @josevalim 's comment is valid: as it is, when both the parent and the child router define a host, only the child's host is shown. I think that's misleading because matching enforces both constraints (parent AND child must hold).
I've made a PR to fix this: t3chw#1
Let me know if the approach makes sense.
dpflucas
added a commit
to dpflucas/phoenix
that referenced
this pull request
Aug 27, 2026
Addresses review feedback on phoenixframework#6594: when a route is forwarded, host constraints from both the parent and child router must hold, so combine them instead of letting the child hosts win. Previously a child with an empty hosts list also caused the parent host to be dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6589
This adds host constraints to the
mix phx.routesoutput.Routes defined inside
scopeblocks with ahost:option are now prefixedwith the corresponding host, making it easier to distinguish routes that share
the same path but differ by host.
Example:
Before:
GET /users MyAppWeb.UserController :index
GET /users MyAppWeb.AdminUserController :index
After:
[api.example.com] GET /users MyAppWeb.UserController :index
[admin.example.com] GET /users MyAppWeb.AdminUserController :index