Skip to content

Fix the failing tests #7

Closed
Closed

Description

@settermjd

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

Activity

  1. added
    enhancementNew feature or request
    qaImprovements in quality assurance of the project
    on Nov 25, 2024
  2. self-assigned this
    on Nov 25, 2024
  3. simon-mundy commented on Mar 15, 2025

    @simon-mundy
    Member

    Hi @settermjd I've managed to fix nearly all the tests in PHPUnit. There's some tests that require catching E_WARNING and E_USER_ERROR that PHPUnit will be phasing out in v10. And there's also some at() calls that require fixing. But nearly there.

    The Vagrantfile also works well, but will be much easier to use when we migrate to Docker.

  4. added this to the 3.0.0 milestone on Mar 16, 2025
  5. tyrsson commented on Mar 16, 2025

    @tyrsson
    Member

    I've commented on the issue on another issue, but lets not forget that during this move to satellite packages the relevant test will need to move to the respective satellites since they will no longer be valid in the core package.

  6. settermjd commented on Mar 19, 2025

    @settermjd
    CollaboratorAuthor

    Hi @settermjd I've managed to fix nearly all the tests in PHPUnit. There's some tests that require catching E_WARNING and E_USER_ERROR that PHPUnit will be phasing out in v10. And there's also some at() calls that require fixing. But nearly there.

    The Vagrantfile also works well, but will be much easier to use when we migrate to Docker.

    I've created #30 to phase out Docker, if you have a moment.

  7. settermjd commented on Mar 20, 2025

    @settermjd
    CollaboratorAuthor

    Looks like the event code needs to be refactored.

  8. settermjd commented on Mar 20, 2025

    @settermjd
    CollaboratorAuthor

    @simon-mundy, have you merged your changes to fix the tests, or is that still coming?

  9. linked a pull request that will close this issue3.0.x php unit testing fixes pre rfc #38on Apr 14, 2025
  10. modified the milestones: 1.0.0, 0.1.0 on Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestgood first issueGood for newcomersqaImprovements in quality assurance of the project

Type

Projects

  • Status
    Todo

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions