Skip to content

replace adapters by File objects to be more flexible - #89

Merged
mvriel merged 4 commits into
phpDocumentor:developfrom
jaapio:feature/sourceFile
Dec 27, 2015
Merged

mvriel merged 4 commits into
phpDocumentor:developfrom
jaapio:feature/sourceFile

Conversation

@jaapio

@jaapio jaapio commented Dec 27, 2015

Copy link
Copy Markdown
Member

This pr is depending on phpDocumentor/ReflectionCommon#6 therefor a new tag should be created. And the component should be updated in the composer.json/lock

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this test the interface and not the concrete instance?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the interface, use phpDocumentor\Reflection\File as FileSystemFile;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the term Path here might be confusing

@mvriel

mvriel commented Dec 27, 2015

Copy link
Copy Markdown
Member

Missing tests for LocalFile object and CreateCommand?

@jaapio

jaapio commented Dec 27, 2015

Copy link
Copy Markdown
Member Author

tests are added now

mvriel added a commit that referenced this pull request Dec 27, 2015
replace adapters by File objects to be more flexible
@mvriel
mvriel merged commit 32b0b0c into phpDocumentor:develop Dec 27, 2015
@jaapio
jaapio deleted the feature/sourceFile branch December 27, 2015 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants