Skip to content

Upgrade to phpunit 9 and drop php 7.2 support - #33

Merged
jaapio merged 1 commit into
phpDocumentor:2.xfrom
DIOHz0r:2.x
Oct 6, 2020
Merged

jaapio merged 1 commit into
phpDocumentor:2.xfrom
DIOHz0r:2.x

Conversation

@DIOHz0r

@DIOHz0r DIOHz0r commented Oct 4, 2020 •

Copy link
Copy Markdown
Contributor

As part of Hacktoberfest, I want to help with issue #32

@DIOHz0r
DIOHz0r force-pushed the 2.x branch 2 times, most recently from efc656a to 292145a Compare October 4, 2020 03:51
Comment thread composer.json Resolved

@jaapio jaapio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR,

I added a small comment about phpunit, and our pipeline has detected an issue. Could you please have a look at those changes?

@DIOHz0r
DIOHz0r force-pushed the 2.x branch 4 times, most recently from d12e30c to 1d29208 Compare October 5, 2020 19:50
@DIOHz0r

DIOHz0r commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Hello, finally all fixes where applied

@jaapio
jaapio merged commit 9ac40b2 into phpDocumentor:2.x Oct 6, 2020
@jaapio

jaapio commented Oct 6, 2020

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants