Repository navigation
Upgrade to phpunit 9 and drop php 7.2 support - #33
Merged
Merged
Conversation
DIOHz0r
force-pushed
the
2.x
branch
2 times, most recently
from
October 4, 2020 03:51
efc656a to
292145a
Compare
jaapio
reviewed
Oct 4, 2020
jaapio
requested changes
Oct 4, 2020
jaapio
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR,
I added a small comment about phpunit, and our pipeline has detected an issue. Could you please have a look at those changes?
DIOHz0r
force-pushed
the
2.x
branch
4 times, most recently
from
October 5, 2020 19:50
d12e30c to
1d29208
Compare
Contributor
Author
|
Hello, finally all fixes where applied |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of Hacktoberfest, I want to help with issue #32