Skip to content

Remove graduated primer_react_action_list_item_gap feature flag - #8380

Open
jonrohan with Copilot wants to merge 3 commits into
mainfrom
copilot/remove-primer-react-action-list-item-gap
Open

Remove graduated primer_react_action_list_item_gap feature flag#8380
jonrohan with Copilot wants to merge 3 commits into
mainfrom
copilot/remove-primer-react-action-list-item-gap

Conversation

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Overview

Graduate the primer_react_action_list_item_gap feature flag so NavList item gaps are enabled by default. Remove the flag from the default feature-flag scope and update the related stories, tests, and changelog entry.

Changelog

New

  • None.

Changed

  • NavList item gaps are now enabled by default.
  • Updated NavList stories and tests to reflect the default behavior.

Removed

  • The primer_react_action_list_item_gap feature flag.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • Focused tests: 91 passed
  • Full test suite: 2,633 passed, 2 skipped, 10 todo
  • Type-check, build, lint, CSS lint, and format checks passed
  • CodeQL reported 0 JavaScript alerts

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9d98d65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copilot AI requested a review from jonrohan September 3, 2026 21:33
Copilot stopped work on behalf of jonrohan due to an error September 3, 2026 21:33
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@jonrohan jonrohan changed the title [WIP] Remove graduated primer_react_action_list_item_gap feature flag Remove graduated primer_react_action_list_item_gap feature flag Sep 4, 2026
Updated CHANGELOG with recent patch changes including improvements to NavList and Breadcrumbs.
@jonrohan
jonrohan marked this pull request as ready for review September 4, 2026 16:44
Copilot AI lite review requested due to automatic review settings September 4, 2026 16:44
@jonrohan
jonrohan requested a review from a team as a code owner September 4, 2026 16:44
@primer-integration

primer-integration Bot commented Sep 4, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Failed  CI   Failed
Running  VRT   Running
Passed  Projects   Passed

CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures.

Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8380 September 4, 2026 16:45 Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The flag is fully removed from the runtime path and defaults, and the associated tests/stories/changeset are updated consistently with no remaining in-code references.

Pull request overview

This PR graduates the primer_react_action_list_item_gap feature flag so NavList item spacing is enabled by default, and removes the flag from the default feature flag registry. It also updates tests, stories, and adds a changeset for a patch release.

Changes:

  • Enable NavList item gaps by default by removing the feature-flag gate in ActionList when container === 'NavList'.
  • Update NavList and ActionList tests and NavList feature stories to reflect the new default behavior (and remove FeatureFlags wrappers for this behavior).
  • Remove primer_react_action_list_item_gap from DefaultFeatureFlags and add a patch changeset.
File summaries
File Description
packages/react/src/NavList/NavList.test.tsx Updates assertions to expect item gaps by default and removes feature-flag-specific cases.
packages/react/src/NavList/NavList.features.stories.tsx Removes feature-flag wrapper and renames the story to reflect default behavior.
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Removes the graduated flag from the default flag scope.
packages/react/src/ActionList/List.tsx Makes data-item-gap unconditional for NavList container (no feature flag).
packages/react/src/ActionList/ActionList.test.tsx Removes now-obsolete test for “flag enabled” behavior while keeping standalone default behavior coverage.
.changeset/nav-list-item-gaps.md Adds patch changeset documenting the default behavior change.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 4, 2026
@github-actions github-actions Bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh update snapshots 🤖 Command that updates VRT snapshots on the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants