Remove graduated primer_react_action_list_item_gap feature flag#8380
Conversation
🦋 Changeset detectedLatest commit: 9d98d65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
|
Updated CHANGELOG with recent patch changes including improvements to NavList and Breadcrumbs.
|
Integration test results from github/github-ui PR:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
There was a problem hiding this comment.
🟢 Approval recommended
The flag is fully removed from the runtime path and defaults, and the associated tests/stories/changeset are updated consistently with no remaining in-code references.
Pull request overview
This PR graduates the primer_react_action_list_item_gap feature flag so NavList item spacing is enabled by default, and removes the flag from the default feature flag registry. It also updates tests, stories, and adds a changeset for a patch release.
Changes:
- Enable NavList item gaps by default by removing the feature-flag gate in
ActionListwhencontainer === 'NavList'. - Update NavList and ActionList tests and NavList feature stories to reflect the new default behavior (and remove FeatureFlags wrappers for this behavior).
- Remove
primer_react_action_list_item_gapfromDefaultFeatureFlagsand add a patch changeset.
File summaries
| File | Description |
|---|---|
| packages/react/src/NavList/NavList.test.tsx | Updates assertions to expect item gaps by default and removes feature-flag-specific cases. |
| packages/react/src/NavList/NavList.features.stories.tsx | Removes feature-flag wrapper and renames the story to reflect default behavior. |
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Removes the graduated flag from the default flag scope. |
| packages/react/src/ActionList/List.tsx | Makes data-item-gap unconditional for NavList container (no feature flag). |
| packages/react/src/ActionList/ActionList.test.tsx | Removes now-obsolete test for “flag enabled” behavior while keeping standalone default behavior coverage. |
| .changeset/nav-list-item-gaps.md | Adds patch changeset documenting the default behavior change. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Overview
Graduate the
primer_react_action_list_item_gapfeature flag so NavList item gaps are enabled by default. Remove the flag from the default feature-flag scope and update the related stories, tests, and changelog entry.Changelog
New
Changed
Removed
primer_react_action_list_item_gapfeature flag.Rollout strategy
Testing & Reviewing