Conversation
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
|
|
| min-release-age-exclude[]=vitest | ||
| min-release-age-exclude[]=@vitest/* | ||
| min-release-age-exclude[]=tinybench |
There was a problem hiding this comment.
| min-release-age-exclude[]=vitest | |
| min-release-age-exclude[]=@vitest/* | |
| min-release-age-exclude[]=tinybench |
There was a problem hiding this comment.
🟡 Changes recommended
Vitest 5’s Node engine floor (>=22.12) appears to conflict with the repo’s declared Node engine support (allows 22.11), which should be aligned to prevent install/test issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Migrates the repo’s test tooling from Vitest 4 to Vitest 5, keeping existing behavior stable while accounting for Vitest’s new package set and some async timing differences in tests.
Changes:
- Upgrades
vitest,@vitest/browser, and@vitest/browser-playwrightto^5.0.0and aligns the internal@primer/vitest-configpeer dependency. - Adds npm
min-release-ageexclusions for the newly released Vitest packages andtinybenchto avoid install blocks during the initial release window. - Updates a
SelectPaneltest to usewaitForinstead of a 0ms timer tick to accommodate async updates.
File summaries
| File | Description |
|---|---|
| packages/vitest-config/package.json | Bumps the internal shared config’s vitest peer dependency to v5. |
| packages/react/src/SelectPanel/SelectPanel.test.tsx | Replaces a timer-based assertion with waitFor for async stability. |
| package.json | Updates root devDependencies to Vitest 5-related packages. |
| package-lock.json | Lockfile updates reflecting Vitest 5 and its updated dependency tree (including new engine constraints). |
| .npmrc | Temporarily exempts Vitest-related packages and tinybench from npm’s release-age policy. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Integration test results from github/github-ui PR:
All checks passed! |
Migrates the test infrastructure from Vitest 4 to Vitest 5 while preserving existing test behavior.
Changelog
New
Changed
vitest,@vitest/browser, and@vitest/browser-playwrightto v5.tinybenchfrom npm’s release-age policy.waitForto account for asynchronous updates.Removed
Rollout strategy
Testing & Reviewing
Review the dependency graph, temporary release-age exclusions, and Vitest 5 migration compatibility.