Add support for persistent disk naming for DiskUsage collector#483
Merged
shortdudey123 merged 3 commits intopython-diamond:masterfrom Jul 29, 2022
Merged
Add support for persistent disk naming for DiskUsage collector#483shortdudey123 merged 3 commits intopython-diamond:masterfrom
shortdudey123 merged 3 commits intopython-diamond:masterfrom
Conversation
Uses pyudev to extract device specific model (ID_MODEL) and serial number (ID_SERIAL) to construct a unique, persistent name that is similar to the device naming convention used in /dev/disk/by-id/... This will only work with devices that provide ID_MODEL and ID_SERIAL fields.
Member
|
Can you remove the overlap with #482 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for using ID_MODEL and ID_SERIAL for persistent naming of devices.
Very useful in large disk environments to get consistent naming.