gh-104341: Add a Separate "Running" Lock for Each Thread#104754
Merged
ericsnowcurrently merged 4 commits intopython:mainfrom May 23, 2023
Merged
gh-104341: Add a Separate "Running" Lock for Each Thread#104754ericsnowcurrently merged 4 commits intopython:mainfrom
ericsnowcurrently merged 4 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a separate lock means
Thread.join()doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some flexibility in how we clean up threads.(This is
a minor cleanup aspart of a fix for gh-104341.)