Skip to content

GH-118095: Add tier 2 support for YIELD_VALUE #118380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 3 commits into from
Apr 30, 2024
Merged

GH-118095: Add tier 2 support for YIELD_VALUE #118380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e1b870
Add tier 2 support for YIELD_VALUE
markshannon Apr 29, 2024
27a2f3f
No entry_frame in tier 2
markshannon Apr 29, 2024
71a203a
_PyOpcode_Deopt isn't available to the JIT
markshannon Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No entry_frame in tier 2
  • Loading branch information
@markshannon
markshannon committed Apr 29, 2024
commit 27a2f3f546310dbc3dceeb76789f1d41b38fa3e3
2 changes: 2 additions & 0 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,9 @@ dummy_func(
// NOTE: It's important that YIELD_VALUE never raises an exception!
// The compiler treats any exception raised here as a failed close()
// or throw() call.
#if TIER_ONE
assert(frame != &entry_frame);
#endif
frame->instr_ptr++;
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if the DSL had a symbol for "this instruction's size".

Copy link
Copy Markdown
Member Author

@markshannon markshannon Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#118423

PyGenObject *gen = _PyFrame_GetGenerator(frame);
assert(FRAME_SUSPENDED_YIELD_FROM == FRAME_SUSPENDED + 1);
Expand Down
2 changes: 2 additions & 0 deletions Python/executor_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.