GH-123040: Specialize shadowed LOAD_ATTR.#123219
Merged
markshannon merged 12 commits intopython:mainfrom Aug 23, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specializes
LOAD_ATTRfor shadowed attributes, where the shadowing doesn't change the attribute.Stats show a 30% reduction in specialization failures for
LOAD_ATTR.Performance might show a slight speedup, but is more likely just noise.
LOAD_ATTRandSTORE_ATTRwhen attributes are shadowed by the object's class. #123040