Skip to content

gh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM Android on 64-bit ARM kernel#145617

Merged
encukou merged 3 commits intopython:mainfrom
robertkirkman:sysconfig-32-bit-arm-android-64-bit-arm-kernel
Mar 26, 2026
Merged

gh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM Android on 64-bit ARM kernel#145617
encukou merged 3 commits intopython:mainfrom
robertkirkman:sysconfig-32-bit-arm-android-64-bit-arm-kernel

Conversation

@robertkirkman
Copy link
Copy Markdown
Contributor

@robertkirkman robertkirkman commented Mar 7, 2026 •
edited by mhsmith
Loading

  • When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, os.uname().machine is armv8l. Such devices run the same userspace code as armv7l devices, so apply the same armeabi_v7a Android ABI to them, which works.

@robertkirkman robertkirkman requested a review from FFY00 as a code owner March 7, 2026 02:37
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Mar 7, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 7, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Mar 7, 2026
Closed
@encukou encukou requested a review from mhsmith March 9, 2026 13:27
@mhsmith
Copy link
Copy Markdown
Member

mhsmith commented Mar 13, 2026

Thanks, I'll look at this in the next few days.

@robertkirkman
Copy link
Copy Markdown
Contributor Author

robertkirkman commented Mar 15, 2026

I have provided additional follow-up information here

@mhsmith mhsmith added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 23, 2026
mhsmith
mhsmith reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks fine, but please also update the corresponding code in test_get_platform in test_sysconfig.py.

robertkirkman and others added 2 commits March 23, 2026 19:52
@robertkirkman
pythongh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM…
799fb36 
… Android on 64-bit ARM kernel

- When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works.

- Issue: python#145616
@blurb-it @robertkirkman
📜🤖 Added by blurb_it.
b01cf02
@robertkirkman robertkirkman force-pushed the sysconfig-32-bit-arm-android-64-bit-arm-kernel branch from eb69366 to b01cf02 Compare March 24, 2026 00:52
@robertkirkman
Copy link
Copy Markdown
Contributor Author

robertkirkman commented Mar 24, 2026

Thank you for pointing that out, I didn't notice that code previously. I hope I've updated it correctly now.

@robertkirkman
Copy link
Copy Markdown
Contributor Author

robertkirkman commented Mar 24, 2026 •
edited
Loading

Also, pardon me for asking, but when you put the "needs backport to 3.13" and "needs backport to 3.14" labels on this, does that mean that I should open follow-up PRs afterward targeting those branches of Python, or will you do that?
I targeted the development branch which is, I suppose, Python 3.15. I'm aware that this patch would need slight editing to apply to Python 3.13 and that it would work when applied there, but I can do that if necessary.

mhsmith
mhsmith approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, it will be done automatically by a bot when this PR is merged, which I hope @encukou can do now.

@encukou encukou merged commit 3a2b81e into python:main Mar 26, 2026
48 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 26, 2026

Thanks @robertkirkman for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 26, 2026
@robertkirkman @miss-islington
pythongh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM…
5966592 
… Android on 64-bit ARM kernel (pythonGH-145617)

When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works.
(cherry picked from commit 3a2b81e919103c0be3bc60a47aaa74d34fea6e9e)

Co-authored-by: Robert Kirkman <31490854+robertkirkman@users.noreply.github.com>
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 26, 2026

Sorry, @robertkirkman and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3a2b81e919103c0be3bc60a47aaa74d34fea6e9e 3.13

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 26, 2026

GH-146464 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 26, 2026
vstinner pushed a commit that referenced this pull request Mar 27, 2026
@miss-islington @robertkirkman
[3.14] gh-145616: Detect Android sysconfig ABI correctly on 32-bit AR…
70affe0 
…M Android on 64-bit ARM kernel (GH-145617) (#146464)

gh-145616: Detect Android sysconfig ABI correctly on 32-bit ARM Android on 64-bit ARM kernel (GH-145617)

When Python is running on 32-bit ARM Android on a 64-bit ARM kernel, `os.uname().machine` is `armv8l`. Such devices run the same userspace code as `armv7l` devices, so apply the same `armeabi_v7a` Android ABI to them, which works.
(cherry picked from commit 3a2b81e)

Co-authored-by: Robert Kirkman <31490854+robertkirkman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhsmith mhsmith mhsmith approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

@encukou encukou

Labels

needs backport to 3.13 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip install does not work in Python 3.13 on 32-bit ARM Android running on 64-bit ARM kernel

3 participants

@robertkirkman @mhsmith @encukou