gh-145176 Move Emscripten files into Platforms/emscripten#145806
gh-145176 Move Emscripten files into Platforms/emscripten#145806freakboy3742 merged 10 commits intopython:mainfrom
Conversation
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit e8221bd 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145806%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 6257cd3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145806%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
left a comment
There was a problem hiding this comment.
The bones of this all look straightforward; I've flagged a couple of things inline, including the directory simplification that I raised during the last PR.
There's also evidently still an issue with testing - I'm guessing it's the path depth in playwright.config.ts. That will also need to be updated for the path simplification - and if there's a way to make it work with a custom cross-build folder, that would be even better.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit f37ffda 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145806%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 16f8054 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145806%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot Emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit f3994ed 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145806%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Okay, I think I updated it with the requested changes and CI seems green now @freakboy3742 |
|
Thanks for those updates. There's still an issue with the playwright test not working outside the |
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…onGH-145806) Moves Emscripten build files into Platforms/emscripten. (cherry picked from commit 1b118353bb0a9d816de6ef673f3b11775de5bec5) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-146043 is a backport of this pull request to the 3.14 branch. |
|
@hoodmane It occurs to me that the dev guide will also need an update when the old entry point is deprecated/removed. |
To see the diff in
__main__.pylook at just the first commit.