Skip to content

bpo-30570: Fix segfault on buildbots caused by stack overflow from recursion in tests #29258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 2 commits into from
Oct 28, 2021
Merged

bpo-30570: Fix segfault on buildbots caused by stack overflow from recursion in tests #29258

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8697f
Don't stackoveflow on debug builds
sweeneyde Oct 28, 2021
7f4ebfa
Also catch the pickletester case
sweeneyde Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also catch the pickletester case
  • Loading branch information
@sweeneyde
sweeneyde committed Oct 28, 2021
commit 7f4ebfae67327a2ea02e0f5da086110d72474b38
3 changes: 2 additions & 1 deletion Lib/test/pickletester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,7 +2383,8 @@ def test_bad_getattr(self):
# Issue #3514: crash when there is an infinite loop in __getattr__
x = BadGetattr()
for proto in protocols:
self.assertRaises(RuntimeError, self.dumps, x, proto)
with support.infinite_recursion():
self.assertRaises(RuntimeError, self.dumps, x, proto)

def test_reduce_bad_iterator(self):
# Issue4176: crash when 4th and 5th items of __reduce__()
Expand Down