Skip to content

allow import "path/style.css" inside jsx (update webpack.config.js bo…#50

Merged
timelyportfolio merged 2 commits intoreact-R:masterfrom
DivadNojnarg:webpack-config-css-rule
Feb 16, 2021
Merged

allow import "path/style.css" inside jsx (update webpack.config.js bo…#50
timelyportfolio merged 2 commits intoreact-R:masterfrom
DivadNojnarg:webpack-config-css-rule

Conversation

@DivadNojnarg
Copy link
Contributor

This will allow:

import "path-to-css/style.min.css";

inside any srcjs/file.jsx without crashing yarn run webpack. Maybe there was a reason not to put it. Let me know ;)

@timelyportfolio
Copy link
Collaborator

@DivadNojnarg I am good with this change. Then hopefully you can eliminate the override section in your book. I'll plan to merge this along with #49 and #45, update React, and then submit to CRAN over the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants