list class #82, hydrate tags in attribs #67, switch to vite/vitest#83
Merged
timelyportfolio merged 19 commits intomasterfrom Jun 28, 2024
Merged
list class #82, hydrate tags in attribs #67, switch to vite/vitest#83timelyportfolio merged 19 commits intomasterfrom
list class #82, hydrate tags in attribs #67, switch to vite/vitest#83timelyportfolio merged 19 commits intomasterfrom
Conversation
…lwidgets` will recurse through extracting `htmlwidgets::JS` calls
list in reactR::component class list to #82 list in reactR::component class list to #82
…dle `shiny.tag` as prop #67
1 task
list in reactR::component class list to #82 list class #82, hydrate tags in attribs #67, switch to vite/vitest
Collaborator
Author
|
@glin wondering if I could request another big favor to check this pull request? |
Contributor
|
@timelyportfolio Looks good to me. reactable doesn't do any passing of tags as props so it should be unaffected, and I can't think of any side effects either. |
Collaborator
Author
|
@glin sorry for the very long delay in pushing this to CRAN. I plan to submit today. Thanks for all your help reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
componentretainslist#82 insurereactR::componentretainslistin class listwebpack/karmawith the more modernvite/vitest