Skip to content

sys has been deprecated - convert usage to util - #24

Merged
robrighter merged 1 commit into
robrighter:masterfrom
jmalonzo:master
Mar 7, 2012
Merged

robrighter merged 1 commit into
robrighter:masterfrom
jmalonzo:master

Conversation

@jmalonzo

Copy link
Copy Markdown
Contributor

Hi Rob,

The sys module has been deprecated so I changed it's usage in node-xml to util. I'd appreciate the review and possible merge the changes.

Thanks.

Jan

@bigeasy

bigeasy commented Mar 7, 2012

Copy link
Copy Markdown

Please apply. Also, @jmalonzo, the use of sys in node-xml.js is superfluous. You can delete those lines.

robrighter added a commit that referenced this pull request Mar 7, 2012
sys has been deprecated - convert usage to util
@robrighter
robrighter merged commit d79daf6 into robrighter:master Mar 7, 2012
@bigeasy

bigeasy commented Mar 7, 2012

Copy link
Copy Markdown

Thank you for applying the pull request. I'm still not seeing the module at npmjs.org, though.

http://search.npmjs.org/#/node-xml

@robrighter

Copy link
Copy Markdown
Owner

Just published it to npm. The new version is 1.0.1.

@bigeasy

bigeasy commented Mar 8, 2012

Copy link
Copy Markdown

Yup. No more bellyaching on the console. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants