Conversation
sid-rl
reviewed
Feb 27, 2026
Contributor
sid-rl
left a comment
There was a problem hiding this comment.
it's fine if you want to make the docstring changes in this pr, just make sure it's consistent across all the classes (sync and async)
Contributor
There was a problem hiding this comment.
why are we deleting this file?
| print("Set ANTHROPIC_API_KEY for Claude Code.", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| sdk = RunloopSDK() |
Contributor
There was a problem hiding this comment.
should prefer using AsyncRunloopSDK for all our examples/docs
Contributor
There was a problem hiding this comment.
why are we updating these docstrings in this pr? also if we're making these changes, we should mirror them for the async classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.